Skip to content

Feat/docstore rename delete actions (optimised for dark theme)#6144

Merged
HenryHengZJ merged 2 commits intoFlowiseAI:mainfrom
sahil2448:feat/docstore-rename-delete-actions
Apr 7, 2026
Merged

Feat/docstore rename delete actions (optimised for dark theme)#6144
HenryHengZJ merged 2 commits intoFlowiseAI:mainfrom
sahil2448:feat/docstore-rename-delete-actions

Conversation

@sahil2448
Copy link
Copy Markdown
Contributor

@sahil2448 sahil2448 commented Apr 3, 2026

optimized docstore's rename/delete feature for dark theme

fix(ui): improve dark theme contrast for docstore action menu button


Summary

This PR addresses reviewer feedback about the 3-dot action button (rename/delete menu) not being visually clear in dark theme.


What I changed

  • Updated the 3-dot action IconButton styling in both docstore views:
    • Grid/Card view
    • Table/List view
  • Made the button theme-aware for:
    • Icon color
    • Background color
    • Border color
    • Hover border contrast
Screen.Recording.2026-04-03.231345.mp4

Why this change

In dark mode, the old button colors had low contrast. This update improves visibility while keeping the same behavior and UI flow.


Scope

  • UI styling only
  • No business logic changes
  • No API/state changes

Verification

  • Built UI successfully:
    npm --prefix packages/ui run build

@sahil2448 sahil2448 changed the title Feat/docstore rename delete actions Feat/docstore rename delete actions (optimised for dark theme) Apr 3, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces management actions for document stores, including rename and delete capabilities in both card and table views. It adds action menus, permission-based access control, and local state management to improve the user experience during store modifications. Feedback provided suggests using unique IDs for React keys, consolidating duplicated styles for action buttons, and refactoring error message parsing for better maintainability.

Comment thread packages/ui/src/views/docstore/index.jsx Outdated
Comment thread packages/ui/src/ui-component/table/DocumentStoreTable.jsx Outdated
Comment thread packages/ui/src/views/docstore/index.jsx
@HenryHengZJ
Copy link
Copy Markdown
Contributor

thanks for following up, do you have recordings or screenshots?

@sahil2448
Copy link
Copy Markdown
Contributor Author

thanks for following up, do you have recordings or screenshots?

@HenryHengZJ
I have Just added a video in the PR....(I actually forgot to add it initially)

Comment thread packages/ui/src/views/docstore/actionButtonStyles.js Outdated
@HenryHengZJ HenryHengZJ merged commit edff152 into FlowiseAI:main Apr 7, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants